Feature/compilefix #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix compile errors from fswthru addition in scale_fluxes change case of "orion" in clean backend
…sed. The current construction did not use the calculated values as they were defined private and overwritten at each i/j (CICE-Consortium#507)
* deprecate upwind advection * fix diagnostic info * remove single quotes * error message if upwind is used
The documentation states that this test case sets 'coriolis' to zero, but 'configuration/scripts/options/set_nml.box2001' sets 'coriolis' to 'constant'. Fix the documentation to be in line with the code. While at it, add the correct unit for the Coriolis parameter (in both places where it appears in the documentation). Closes CICE-Consortium#509 Reported-by: Jean-François Lemieux <jean-francois.lemieux@canada.ca>
Ice pressure is different from ice strength, so remove 'pressure' from the description of 'ice strength'.
DeniseWorthen
requested review from
XiujuanSu-NOAA,
junwang-noaa,
binli2337 and
JessicaMeixner-NOAA
and removed request for
XiujuanSu-NOAA
junwang-noaa
approved these changes
Aug 31, 2020
binli2337
approved these changes
Aug 31, 2020
|
Do I still need to review it?
Su
…On Mon, Aug 31, 2020 at 12:53 PM Denise Worthen ***@***.***> wrote:
Merged #17 <#17> into emc/develop.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#17 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AP5S7HQZXMAIZE3TFLQCZE3SDPIP5ANCNFSM4QFOFHCQ>
.
|
|
@XiujuanSu-NOAA It was assigned by mistake. I apologize. No need for you to review. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue debug RT fails #16 with fix to icepack (Consoritium issue 502)
Issue need dell-p3 macro file for cice6 #15 adds dell-p3 macro, changes SITE to MACHINE_ID in compile scripts
Dependent NEMS PR #75. NEMS will need to be updated prior to CICE6 commit to S2S.